Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] MATLAB explanations #288

Merged
merged 2 commits into from
May 26, 2023
Merged

[RTM] MATLAB explanations #288

merged 2 commits into from
May 26, 2023

Conversation

EveCharbie
Copy link
Contributor

@EveCharbie EveCharbie commented May 11, 2023

This change is Reviewable

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @EveCharbie)


README.md line 133 at r1 (raw file):

> `BINDER_MATLAB` If you want (`ON`) or not (`OFF`) to build the MATLAB binder. Default is `OFF`.
> 
> `MATLAB_ROOT_DIR` If `BINDER_MATLAB` is set to `ON` then this variable should point to the root path of MATLAB directory (something like /usr/local/MATLAB/R2018a). Please note that the MATLAB binder is based on MATLAB R2018a API and won't compile on earlier versions. This variable should be found automatically, except on Mac where the value should manually be set to the MATLAB in the App folder.

or "C:\Program Files\MATLAB\R2022b" (and maybe 2022b so we don't look too late haha!)


README.md line 143 at r1 (raw file):

> `Octave_ezc3d_INSTALL_DIR` If `BINDER_OCTAVE` is set to `ON` then this variable should point to the path where you want to install EZC3D. Typically, you want this to be in `{MY DOCUMENTS}/Octave`, which is not the default location. The default value is the toolbox folder on root, i.e., `/toolbox`. Please note that if you leave the default value, you will probably need to grant administrator rights to the installer. 

*Fix for MATLAB*: There is a known issue with libstdc++.so.6 in MATLAB. To fix it, you need to copy the libstdc++.so.6 from your system to the MATLAB bin folder. For example, on Ubuntu 18.04, you can do the following:

There is a known issue with libstdc++.so.6 in MATLAB on Ubuntu

Copy link
Contributor Author

@EveCharbie EveCharbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @pariterre)


README.md line 133 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

or "C:\Program Files\MATLAB\R2022b" (and maybe 2022b so we don't look too late haha!)

Done.


README.md line 143 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

There is a known issue with libstdc++.so.6 in MATLAB on Ubuntu

Done.

@EveCharbie EveCharbie changed the title MATLAB explanations [RTM] MATLAB explanations May 15, 2023
Copy link
Contributor Author

@EveCharbie EveCharbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pariterre up :)

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @pariterre)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre pariterre merged commit 6a336d2 into pyomeca:dev May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants