-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This project looks amazing! (I'm getting an error though...) #2
Comments
Hey thanks for this! Yeah it's a little confusing, but I think that pybind11 is needed for the build. Now, that is correctly listed as a dependency in your setup.py I note that there's a setup.py field called btw, the reason that doing |
@joerick thanks for the information! Adding setup_requires gets me a different error which I think comes later but is related. Before, After. Before:
After
Any ideas? |
Could you post the whole 'after' output? I think gcc isn't being invoked with the right include paths... maybe pybind needs to be installed globally for that to work |
Hi @joerick, here's the whole output:
It seems to get one step further now. Before "import pybind11" failed. Now that's succeeding, but when it goes to How would you install globally? |
@joerick This is how the include is done in the demo version of setup.py provided with pybind11 (adapted slightly). Seems reasonable to me, but I'm not totally sure in what order all of these events occur. Kind of strange that I can build the wheel locally no problem...
Interestingly, someone here seems to be having a similar issue: pybind/python_example#18 |
I think that when the project is listed in I'm going to look at adding an option |
Hi @joerick Thanks for getting back to me! That sounds like a great option to add for this use case. Keep me posted on how it goes! |
Hey. I've added that feature, it's available on a feature branch of this repo for now. You can install with Would be interested if this allows you to solve your problem! |
@joerick One of two has run, and it didn't work strangely. Here's my travis file by the way. I'm still waiting for the second build. (oh, and here's my setup.py copied from here. |
You'll need to double-quote the 'pip install ...' environment variable in the travis.yml. Not sure why!
… On 10 Apr 2017, at 23:09, Alexander Lenail ***@***.***> wrote:
@joerick One of two has run, and it didn't work strangely. Here's my travis file by the way. I'm still waiting for the second build.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Hooray! It worked! Got a new error though, which seems to have to do with the compiler? We don't get those error messages when we compile locally... The second build errored in a really interesting way because it seems like it was able to build the wheel but not install it. Strange... Thanks for the help @joerick. What will you do with this new feature? Will you merge into master? |
Boom! Thanks for your help. Yep- i can see it being a useful feature so I'll merge it in
… On 11 Apr 2017, at 01:09, Alexander Lenail ***@***.***> wrote:
Hooray! It worked! Got a new error though, but it looks like it might be on my end. Thanks for the help @joerick. What will you do with this new feature? Will you merge into master?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Ah yeah, on Mac you need to use I added |
Btw, I wrote docs for the option here 2c0d6e3 |
@joerick Amazing! One of the travis builds succeeded! I'm not sure I understand how the two of them are split up? The other one seems to fail because it has the wrong compiler? Link to travis page. Oh I see, it succeeded on mac but failed on linux. |
The thunk? |
@joerick So I would either need to include that .h file in my project or CIBW_SKIP 2.6? I'd much prefer the latter, but it sounds like CIBW_SKIP will be fairly tough to implement? |
@joerick Looks like I'm building all the wheels now in linux with |
I think this is because
p.s. thank you for your patience and help with this! we're ironing out a lot of kinks in this project that will hopefully save a lot of debugging time for future users! 👍 |
Hi @joerick. No worries, I'm happy to go through this. From my perspective, you're one of the most responsive open source developers I've ever had the pleasure to work with! I think this project will be super helpful to me as well as many others, and I'm happy to help out ironing the kinks =) |
Looks like your build failed again https://travis-ci.org/fraenkel-lab/pcst_fast/jobs/221348812 I think I'm guessing the wheel name wrong 🤔 |
@joerick you're one step ahead of me. It's worth noting that when you added |
Turns out it was a weird bug related to setup_requires. Which is now fixed. Let me know how you get on!
|
@joerick Looks like it's all working now! Just need to figure out how to automagically put the wheels on pypi. |
🙌 do you mind if I add your repo to the readme as an example? |
Of course! No Problem! I think that particular repo of ours will be around for a long time. |
@joerick interestingly, we're having a bug with python 3.5 / macOS (which is resolved in the python 3.6 wheel):
Seems like the relevant part is |
Hmm, never seen that before. Anything suspicious in the build log for that wheel? |
Not that I can tell. That's super weird... How is it possible that this successfully installs the wheel on travis but not on real Macs with python 3.5? Could this have to do with minor versions? (I think it fails on 3.5.1, the wheel was built for 3.5.3...) @joerick |
Hello!
I've been looking around for something just like this. I'm a beginner with travis so I hope you'll bear with me.
My code is here and the relevant log file can be found here. I can build wheels locally, upload to pypi and download and install, but my friend can't, so I'm hoping to build many-platform wheels. I think the issue has to do with travis' isolated environments
It looks like it installs pybind11, then installs python, then installs pybind11 again? But then can't find pybind11 when it tries to make the wheel. What do you make of this?
Thanks!
The text was updated successfully, but these errors were encountered: