Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertion error when determining installation order. #10867

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Fix assertion error when determining installation order. #10867

merged 4 commits into from
Feb 3, 2022

Conversation

mauritsvanrees
Copy link
Contributor

Fixes #10851

@mauritsvanrees mauritsvanrees mentioned this pull request Jan 31, 2022
Closed
1 task
@pradyunsg pradyunsg mentioned this pull request Feb 1, 2022
Closed
pradyunsg
pradyunsg reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test that ensure that things work even when there's a cycle + restricting one of the nodes in the cycle.

@mauritsvanrees
Copy link
Contributor Author

This needs a test that ensure that things work even when there's a cycle + restricting one of the nodes in the cycle.

I have now added two extra test cases for this.

pradyunsg
pradyunsg reviewed Feb 3, 2022
View reviewed changes
news/10851.bugfix.rst Outdated Show resolved Hide resolved
@pradyunsg pradyunsg merged commit ff8dbb4 into pypa:main Feb 3, 2022
@mauritsvanrees mauritsvanrees deleted the maurits-topoligical-weights-requirements-only-issue-10851 branch February 3, 2022 09:37
@pradyunsg
Copy link
Member

Thanks @mauritsvanrees! This is in 22.0.3.

@mauritsvanrees
Copy link
Contributor Author

Great! Thanks for the reviews @pradyunsg and @uranusjr !

@mauritsvanrees mauritsvanrees mentioned this pull request Feb 3, 2022
Merged
humitos added a commit to readthedocs/readthedocs.org that referenced this pull request Feb 3, 2022
@humitos
Builder: unpin pip
e90b260 
It seems the problem with pip was solved in
pypa/pip#10867 and 22.0.3 version was released with this
fix.
@humitos humitos mentioned this pull request Feb 3, 2022
Merged
@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Feb 8, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr left review comments

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

22.0: assert len(weights) == expected_node_count AssertionError
3 participants
@mauritsvanrees @pradyunsg @uranusjr