Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI support for Python 3.11 #11285

Closed
wants to merge 3 commits into from
Closed

Add CI support for Python 3.11 #11285

wants to merge 3 commits into from

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jul 21, 2022

No description provided.

@sbidoul
Copy link
Member Author

sbidoul commented Jul 21, 2022

Hm, looks like virtualenv<20 does not work with python 3.11 ?
Why is it again that our tests can't use the latest virtualenv ?

@sbidoul sbidoul added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jul 21, 2022
@SpecLad
Copy link
Contributor

SpecLad commented Jul 21, 2022

Relevant: #8273

@sbidoul
Copy link
Member Author

sbidoul commented Jul 21, 2022

Ah, the good news is that our tests seem to pass with the latest virtualenv on python <= 3.10. I'm not sure virtualenv supports python 3.11 yet, though.

@SpecLad
Copy link
Contributor

SpecLad commented Jul 21, 2022

Ah, the good news is that our tests seem to pass with the latest virtualenv on python <= 3.10

You didn't update the virtualenv version in tests/requirements.txt, so the tests still ran using virtualenv 19.

@sbidoul
Copy link
Member Author

sbidoul commented Jul 21, 2022

🤦Thanks.

@sbidoul sbidoul closed this Jul 21, 2022
@pradyunsg
Copy link
Member

x-ref #11288

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants