fix for certain platforms/versions not having os.O_NOFOLLOW
#1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may be a silly question, but can we use a Either way this patch looks reasonable to me. |
|
I think in the past, that split could have been done, but with #906 on the radar, I wasn't thinking in those terms. |
|
Not necessarily, just thinking out loud :) |
qwcode
added a commit
that referenced
this pull request
Nov 26, 2013
fix for certain platforms/versions not having `os.O_NOFOLLOW`
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #849.
this is critical for the PEP453 effort in python 3.4: http://bugs.python.org/issue19749
needs confirmation from another person, as it contains a fair amount of tedium
I did add new tests.
cc @d1b