Skip to content

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Sep 21, 2025

This changes how the final blurb is presented.

Before:

$ pip install shrinkwrap --dry-run --no-binary :all:
Collecting shrinkwrap
  Using cached shrinkwrap-0.10.tar.gz (6.0 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [25 lines of output]
      Traceback (most recent call last):
        File "/Users/pradyunsg/.cache/uv/archive-v0/o8zM1DP1sbfKLaej0Unsx/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
          main()
          ~~~~^^
        File "/Users/pradyunsg/.cache/uv/archive-v0/o8zM1DP1sbfKLaej0Unsx/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 373, in main
          json_out["return_val"] = hook(**hook_input["kwargs"])
                                   ~~~~^^^^^^^^^^^^^^^^^^^^^^^^
        File "/Users/pradyunsg/.cache/uv/archive-v0/o8zM1DP1sbfKLaej0Unsx/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 143, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/private/var/folders/y1/j465wvf92vs938kmgqh63bj80000gn/T/pip-build-env-28rs3nu0/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 331, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
                 ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/y1/j465wvf92vs938kmgqh63bj80000gn/T/pip-build-env-28rs3nu0/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 301, in _get_build_requires
          self.run_setup()
          ~~~~~~~~~~~~~~^^
        File "/private/var/folders/y1/j465wvf92vs938kmgqh63bj80000gn/T/pip-build-env-28rs3nu0/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 512, in run_setup
          super().run_setup(setup_script=setup_script)
          ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/y1/j465wvf92vs938kmgqh63bj80000gn/T/pip-build-env-28rs3nu0/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 317, in run_setup
          exec(code, locals())
          ~~~~^^^^^^^^^^^^^^^^
        File "<string>", line 44
          print '%s/bin/activate has been updated' % VIRTUAL_ENV
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

After:

$ pip install shrinkwrap --dry-run --no-binary :all:    
Collecting shrinkwrap
  Using cached shrinkwrap-0.10.tar.gz (6.0 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [25 lines of output]
      Traceback (most recent call last):
        File "/Users/pradyunsg/Developer/github/pip/src/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
          main()
          ~~~~^^
        File "/Users/pradyunsg/Developer/github/pip/src/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 373, in main
          json_out["return_val"] = hook(**hook_input["kwargs"])
                                   ~~~~^^^^^^^^^^^^^^^^^^^^^^^^
        File "/Users/pradyunsg/Developer/github/pip/src/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 143, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/private/var/folders/y1/j465wvf92vs938kmgqh63bj80000gn/T/pip-build-env-oytda564/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 331, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
                 ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/y1/j465wvf92vs938kmgqh63bj80000gn/T/pip-build-env-oytda564/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 301, in _get_build_requires
          self.run_setup()
          ~~~~~~~~~~~~~~^^
        File "/private/var/folders/y1/j465wvf92vs938kmgqh63bj80000gn/T/pip-build-env-oytda564/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 512, in run_setup
          super().run_setup(setup_script=setup_script)
          ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/y1/j465wvf92vs938kmgqh63bj80000gn/T/pip-build-env-oytda564/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 317, in run_setup
          exec(code, locals())
          ~~~~^^^^^^^^^^^^^^^^
        File "<string>", line 44
          print '%s/bin/activate has been updated' % VIRTUAL_ENV
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed to build 'shrinkwrap' when getting requirements to build wheel

@pradyunsg pradyunsg self-assigned this Sep 21, 2025
@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Sep 21, 2025
@pradyunsg pradyunsg marked this pull request as ready for review September 22, 2025 19:06
Copy link
Member

@notatallshaw notatallshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pradyunsg pradyunsg merged commit 56e5b4d into pypa:main Sep 25, 2025
28 checks passed
@pradyunsg pradyunsg deleted the better-error-reportin branch September 25, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants