Skip to content

try fix encode error #4251 #4280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

try fix encode error #4251 #4280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cbee88
try fix encode error #4251
robinxb Feb 11, 2017
2fd6951
Merge branch 'master' into patch-1
robinxb Apr 1, 2017
0d6c235
add new entry
robinxb Apr 1, 2017
d1de4fc
add replace error handler to decode, remove catch ImportError on windows
robinxb Apr 5, 2017
c7d43df
use getpreferredencoding for console_to_str
robinxb Apr 5, 2017
e7db742
prevent exception while local.getpreferredencoding return None
robinxb May 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/4280.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a ``UnicodeDecodeError`` when try install some package on some non-english systems.
6 changes: 2 additions & 4 deletions pip/compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import os
import sys
import locale

from pip._vendor.six import text_type

Expand Down Expand Up @@ -38,10 +39,7 @@

if sys.version_info >= (3,):
def console_to_str(s):
try:
return s.decode(sys.__stdout__.encoding)
except UnicodeDecodeError:
return s.decode('utf_8')
return s.decode(locale.getpreferredencoding() or "utf-8", 'replace')

def native_str(s, replace=False):
if isinstance(s, bytes):
Expand Down