More information about the 'universal' flag. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I first encountered the original comment I found it a bit vague because I didn't really know about wheels. I knew that the package I wanted to make wouldn't work on Python 2 so I didn't want to make a universal wheel. But I had to research how this line needed to be changed to do what I wanted, and ended up reading the bdist_wheel.py source to find the answer, which seems excessively difficult. These changes hopefully make it more obvious what to do in my situation.
pfmoore
reviewed
Apr 26, 2018
setup.cfg
Outdated
| # support. Setting the value of 'universal' to anything other than '1', | ||
| # 'true' or 'yes' (case insensitive) or removing this line will prevent | ||
| # bdist_wheel from trying to make a universal wheel. For more see: | ||
| # https://packaging.python.org/tutorials/distributing-packages/#wheels |
There was a problem hiding this comment.
Trying to give the whole story here seems likely to confuse people. I'd prefer the addition to just say "Removing this line (or setting universal to 0) will prevent..."
There was a problem hiding this comment.
Thanks! I agree, your version is better.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first encountered the original comment I found it a bit vague because I didn't really know about wheels. I knew that the package I wanted to make wouldn't work on Python 2 so I didn't want to make a universal wheel. But I had to research how this line needed to be changed to do what I wanted, and ended up reading the bdist_wheel.py source to find the answer, which seems excessively difficult. These changes hopefully make it more obvious what to do in my situation.