Demonstrate python_requires usage #87
Conversation
setup.py
Outdated
| # install the project if the version does not match. If you support Python 2 | ||
| # or have more complicated version requirements, see | ||
| # https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires | ||
| python_requires='>=3.5', |
There was a problem hiding this comment.
This is at odds with the classifiers above. I'm also concerned about this being missed by folks that fork this repo to start their new project, and not understanding why their package isn't installable with Python 2. Let's make this:
| python_requires='>=3.5', | |
| python_requires='>=2.7', |
There was a problem hiding this comment.
You’re right, I copied over the suggestion from PR #53 and didn’t notice the inconsistency. To be consistent with the classifiers, however, Python versions 3.0 to 3.3 need to be excluded as documented.
Well, to be precise: With the new commit I made, python_requires allows Python 3.8, but the classifiers don’t. I think that’s fine they are used a bit differently (versions in python_requires are and-ed and classifiers are or-ed).
|
Thanks! |
This specifies which versions of Python the library is compatible with. This both prevents the module from being installed in an incompatible Python environment, and will also enable users after future releases to still `pip install musicbrainzngs` and get a version that is compatible with their Python setup. Versions are based on the ones currently being tested for in Travis according to `.travis.yml`. See https://packaging.python.org/guides/dropping-older-python-versions/ and pypa/sampleproject#87 Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Closes #53