refactor: remove joinedload of User #13784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In refactoring the string-based loader to class-based attributes, I found that we do nothing with the resulting user data, we're only looking for existence in the form that uses it. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Simplifies the code a little, since `one_or_none()` does the None-ness for us. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
19 tasks
ewdurbin
approved these changes
May 26, 2023
woodruffw
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In refactoring the string-based loaders to class-based attributes, I
found that we do nothing with the resulting user data from
joinedload("user"),we're only looking for existence of a user-linked macaroon based on
user_id.Simplified query response.
Signed-off-by: Mike Fiedler miketheman@gmail.com