-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
metaMeta issues (rollouts, etc)Meta issues (rollouts, etc)
Description
We've got newer libraries to look at for database accesses, and need a sane workflow to get us to the finish line.
Here's an outline of execution:
- Upgrade to latest SQLAlchemy 1.4.x - done - we're on 1.14.47
- Run tests with
SQLALCHEMY_WARN_20=1
to surface all Deprecation warnings, resolve those post-haste - Set
future=True
onsessionmaker
&create_engine
and run tests- Fails on session passing in
Event.ip_address
magic, which we should probably remove after every Event has a relatedIPAddress
(see feat: add ip address backfill cli command #13804 feat(cli): add input to select event type #13823 refactor: remove calls to ip_address_string #13842) - Fails on test case. Refactor: test: refactor to remove user data from test #13889
- Fails on session passing in
- Upgrade to SQLalchemy 2.0.16 chore(deps): upgrade sqlalchemy #13929
- Nits found while working on SQLAlchemy 2.0 upgrade #13942
- Read https://docs.sqlalchemy.org/en/20/changelog/migration_20.html
- Replace
sqlalchemy-citext
as it's no longer needed, there's a built-in https://docs.sqlalchemy.org/en/20/dialects/postgresql.html#sqlalchemy.dialects.postgresql.CITEXT - fix: update migrations code for sqlalchemy 2.0 #13948
- explicitly send query as text in _health #13950
- Upgrade
psycopg3
- see Upgrade from psycopg2 to psycopg3 #10742 - Upgrade
pytest-postgresql
to 5.x - Celebrate!
Metadata
Metadata
Assignees
Labels
metaMeta issues (rollouts, etc)Meta issues (rollouts, etc)