refactor: SQLAlchemy deprecations #13785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Updates caller syntax to resolve: ``` RemovedIn20Warning: The legacy calling style of select() is deprecated and will be removed in SQLAlchemy 2.0. Please use the new calling style described at select(). ``` Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Resolves: ``` RemovedIn20Warning: Using strings to indicate column or relationship paths in loader options is deprecated and will be removed in SQLAlchemy 2.0. Please use the class-bound attribute directly. ``` Signed-off-by: Mike Fiedler <miketheman@gmail.com>
As a way to allow us to change the `joinedload` calls to class-based, we need to be able to traverse the relationship from the Macaroon-side. Adding `viewonly` to the relationship allows us to know that the related models won't be changed in the context of the loader. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/sqa-warnings
branch
from
98c75a7 to
ebb00a7
Compare
Resolves: ``` RemovedIn20Warning: Passing a chain of multiple join conditions to Query.join() is deprecated and will be removed in SQLAlchemy 2.0. Please use individual join() calls per relationship. ``` Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/sqa-warnings
branch
from
ebb00a7 to
bb4f141
Compare
dstufft
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
and