Skip to content

test: refactor to remove user data from test #13889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2023
Merged

test: refactor to remove user data from test #13889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions tests/unit/accounts/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
TooManyFailedLogins,
TooManyPasswordResetRequests,
)
from warehouse.accounts.models import User
from warehouse.accounts.views import two_factor_and_totp_validate
from warehouse.admin.flags import AdminFlag, AdminFlagValue
from warehouse.events.tags import EventTag
Expand Down Expand Up @@ -535,20 +534,20 @@ def test_two_factor_and_totp_validate_redirect_to_account_login(
to make sure we always compare user.last_login as timezone-aware datetime.

"""
user = User(
user = UserFactory.create(
username="jdoe",
name="Joe",
password="any",
is_active=True,
last_login=datetime.datetime.utcnow() + datetime.timedelta(days=+1),
)
db_request.db.add(user)
db_request.db.commit()
# Make sure object is not in session,
# so sqlalchemy loads it fresh from database and type works it's magic
token_data = {"userid": user.id}

# Remove user object from scope, The `token_service` will load the user
# from the `user_service` and handle it from there
db_request.db.expunge(user)
del user

token_data = {"userid": user.id}
token = token_service.dumps(token_data)
db_request.query_string = token
db_request.find_service = lambda interface, **kwargs: {
Expand Down