test: refactor to remove user data from test #13889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
The intent of this test is to create a user object, run the validation code, and assert that we get redirected. With SQLAlchemy 2.0, calling `user.id` **after** calling `expunge(user)` raises `Parent instance ... is not bound to a Session;` since we manually killed it off. - Replace User with UserFactory (saves some manual db calls) - Move the `token_data` assignment prior to expunge - Add `del user` to be really, really sure it's not around Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/update-test-view
branch
from
d5b1744 to
bdb651b
Compare
di
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this test is to create a user object, run the validation code, and assert that we get redirected.
With SQLAlchemy 2.0, calling
user.idafter callingexpunge(user)raisesParent instance ... is not bound to a Session;since we manually killed it off.token_dataassignment prior to expungedel userto be really, really sure it's not around