xarray for roti #120
xarray for roti #120
Conversation
TST: add _test_load_opt to icon instruments
Co-authored-by: Russell Stoneback <rstoneba@utdallas.edu>
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com> Co-authored-by: Russell Stoneback <rstoneba@utdallas.edu>
Release Candidate v0.0.3
|
Forgot that this has been developed around the load_meta_proc branch from pysat. Happy to close this if it's inappropriate. |
|
I say we keep developing this here and rely on local tests for the merge into the other PR. We can flag that one as waiting for next pysat. |
| @@ -247,7 +499,7 @@ def list_remote_files(tag=None, inst_id=None, start=None, stop=None, | |||
| '1900' will be added for years >= two_digit_year_break | |||
| and '2000' will be added for years < two_digit_year_break. | |||
| (default=None) | |||
| delimiter : string or NoneType | |||
| delimiter : str or NoneType | |||
There was a problem hiding this comment.
Strings don't need NoneType as a default unless there's a really good reason.
There was a problem hiding this comment.
I think I got rid of the NoneType default for all the parameters that don't need it. There were a couple with more involved responses to the None value that I left alone. But I'm not 100% sure they couldn't get by with using '' in place of None
There was a problem hiding this comment.
If you have a list of them, we can go over them at the next meeting.
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
STY: reduce duplication for init and clean
There was a problem hiding this comment.
This looks like a good start. A few style suggestions, but I can load the roti data as an xarray object. Some of the variables listed on cdaweb at https://cdaweb.gsfc.nasa.gov/pub/software/cdawlib/0SKELTABLES/gps_roti15min_jpl_00000000_v01.skt are not present in the loaded data (jan 1, 2014). I only see rotimed and roticnt. I'm not sure if not every file has every value, or if this is an issue on the cdflib side.
| else: | ||
| estr = ''.join(["'time' already present in file. Can't rename ", | ||
| epoch_name, " to 'time'. To load this file ", | ||
| "it may be necessary to set `decode_times=True`."]) |
There was a problem hiding this comment.
This option isn't available here
There was a problem hiding this comment.
removed this
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Co-authored-by: Jeff Klenzing <19592220+jklenzing@users.noreply.github.com> Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
BUG: GOLD metadata
MAINT: use full inheritance in tests
|
This works locally with the latest pysat release. Can't re-run here, needs a commit to trigger this. You could merge in the latest develop changes if needed, but I think it's already downstream of the bug fixes. |
Description
Addresses #92
Added xarray loading of CDF files to cdaweb.py using the cdflib cdf_to_xarray function.
Type of change
How Has This Been Tested?
Data has been loaded and compared to the CDAWEB viewer as well as the local unit tests.
Test Configuration
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changes