Skip to content

Fix paths in files config examples #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix paths in files config examples #167

merged 1 commit into from
Feb 12, 2025

Conversation

danyeaw
Copy link
Contributor

@danyeaw danyeaw commented Feb 12, 2025

As discussed on Discord, the examples for usage of files in the configuration don't seem to be correct for setting the path to a file.

WebReflection
WebReflection approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@WebReflection WebReflection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WebReflection
Copy link
Contributor

@danyeaw do you have merging permissions or should I merge it? (or @ntoll)

@danyeaw
Copy link
Contributor Author

danyeaw commented Feb 12, 2025

I do not have permissions.

@ntoll ntoll merged commit 8d7e004 into pyscript:main Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebReflection WebReflection WebReflection approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danyeaw @WebReflection @ntoll