Skip to content

Fix #83 - Explain in details our pyscript.ffi #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

WebReflection
Copy link
Contributor

This MR fixes #83 by describing with all possible details what's behind our pyscript.ffi and why or when it's needed.

@WebReflection WebReflection requested a review from ntoll April 22, 2024 11:45
@WebReflection WebReflection force-pushed the issue-83 branch 2 times, most recently from ecff5dc to c44f313 Compare April 22, 2024 11:49
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful.

I've annotated some English nit-picks just to make it sound idiomatic and to correct a couple of grammatical mistakes.

Once fixed, let's merge..!

@WebReflection
Copy link
Contributor Author

WebReflection commented Apr 22, 2024

@ntoll all changes addressed, thanks

@WebReflection WebReflection requested a review from ntoll April 22, 2024 12:29
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WebReflection WebReflection merged commit 9606fe0 into main Apr 22, 2024
@WebReflection WebReflection deleted the issue-83 branch April 22, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DocsWeek] The PyScript FFI in a nutshell
2 participants