Skip to content

Move antigravity to module #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 26, 2022
Merged

Move antigravity to module #49

merged 4 commits into from
Apr 26, 2022

Conversation

philippjfr
Copy link
Contributor

@philippjfr philippjfr commented Apr 26, 2022 •
edited
Loading

Moves antigravity to separate module:

  • Add it to repl.html
  • Add it to repl2.html
  • Require invoking .fly() explicitly

antigravity_repl

@philippjfr
Copy link
Contributor Author

philippjfr commented Apr 26, 2022 •
edited
Loading

@fpliger @pzwang I did add a <py-env> to the basic repl example (simply because the import antigravity example looks better when inlined) but maybe it's better to leave the source of that example clean. Let me know what you want me to do here.

@philippjfr philippjfr added status: ready PR that is ready for review tag: example Related to adding or improving examples labels Apr 26, 2022
fpliger
fpliger approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is absolutely amazing! Left a minor comment that we can address later... TY! 🚀

pyscriptjs/examples/antigravity.py

def __init__(self, target=None, interval=10, append=True, fly=False):
target = target or sys.stdout._out
self.target = document.getElementById(target) if isinstance(target, str) else target
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Element(target) instead and Element(target).element will give you the JS object directly

@fpliger fpliger merged commit 67bfff6 into main Apr 26, 2022
@pww217 pww217 deleted the antigravity_enhance branch May 5, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpliger fpliger fpliger approved these changes

Assignees
No one assigned
Labels
status: ready PR that is ready for review tag: example Related to adding or improving examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippjfr @fpliger