Skip to content

Add support to py- events that map all js events available #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2022

Conversation

lpliger
Copy link
Contributor

@lpliger lpliger commented Jun 27, 2022

Closes #470

Remapped all example events using py- instead of pys-
plus added the events list proposed by @ramalho using the py- event

tested locally using make test and manually tested the to do example

@marimeireles
Copy link
Contributor

marimeireles commented Jun 27, 2022

Hey @lpliger I think you're having issues with the linter.
We have zero docs on that I guess, so sorry for that.

A linter is a tool that checks if your code is within the pattern we structure our code in this repo (this could be the amount of spaces between chars, or how you declare types, or even how you write your comments, etc., it's a way of stylizing the code 🙂 so we have it understandable and standardized to everyone).
Ok, so one way of running the linter tool so it standardizes your code for you is to run npm run lint if you have all the local environment built in there, another one is make lint, for now they're doing exactly the same.

If you have any questions regarding this process, feel free to ask!

@marimeireles
Copy link
Contributor

Yep.
Looks great! :)
Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[DISCUSSION] Should we consolidate around pys- as prefix for events mapping?
2 participants