PyNumberMethods record is incorrect for Python 3.x

[LennertP]

The PyNumberMethods record was designed for Python 2.x and still contains nb_divide, nb_coerce, nb_oct, nb_hex and nb_inplace_divide. On the other hand, it lacks nb_index, nb_matrix_multiply and nb_inplace_matrix_multiply. Also, nb_nonzero was renamed as nb_bool and nb_long as nb_reserved. Finally, it has a typo for nb_substract, which should read nb_subtract.

As a result, for Python 3.x e.g. TPythonType_NbPower() will be called when TPythonType_NbNegative() is intended.

[pyscripter]

Could you please supply a test project that demonstrates the issue?

[Alexey-T]

seems very rarely used API.

[LennertP]

Sure, I will create a small example to show the issue later today. These number services are used for operators on user-defined types, e.g. a * b for a and/or b being some TPythonType.

[LennertP]

Please find a simple example project here:
NumberServices.zip
To be able to run this program you will need to point it to a local virtual environment (Search for "TODO:").

[pyscripter]

Thanks. Will have a close look.

[LennertP]

For convenience I herewith provide my version of PythonEngine.pas:
PythonEngine.zip
This version supports both Python 2 and Python 3. Next to these changes it also adds some other minor changes that you may or may not want to include (e.g. PyErr_WarnEx() and PyArg_ParseTupleAndKeywords())

[pyscripter]

Thanks!

[LennertP]

Are you convinced that my changes are correct? Can these eventually be merged in the master version?

[pyscripter]

I am sorry for the delayed response. I will be looking into this soon...

[LennertP]

OK, no problem!

[pyscripter]

@LennertP
Your changes were committed with some adaptations. Please check.
Thanks very much!

[LennertP]

Great, I am glad I was able to add my small contribution to this project!

[Alexey-T]

Thank you !