question about IFDEF in MethodCallback unit

[Alexey-T]

It must go into {$IFNDEF CPUARM} for AArch64 too? on FPC aarch64, CPUARM is not defined, so it goes into. I hope it's OK.

{$IFNDEF CPUARM}
  {$IFDEF CPUX64}
    {$DEFINE 64_BIT_CALLBACK}
  {$ELSE}
    {$IFDEF MACOS}
      {$DEFINE ALIGNED_32_BIT_CALLBACK}
    {$ELSE}
      {$DEFINE SIMPLE_32_BIT_CALLBACK}
    {$ENDIF MACOS}
  {$ENDIF CPUX64}
{$ENDIF CPUARM}  

[pyscripter]

In Delphi CPUARM is defined for [DCCIOSARM64] [DCCAARM] [DCCAARM64] and [DCCOSXARM64]. If Fpc is different, then we need some adjustments in Definitions.inc.

[Alexey-T]

Let’s continue here.

• For “posix” define , see related issue.
• For arm - let’s define CpuArm in the FPC case, when CpuArm64 is defined.

[pyscripter]

Regarding POSIX in definition.inc we have:

  {$IFDEF UNIX}
    {$DEFINE POSIX}
  {$ENDIF UNIX}

This covers both Linux and MacOS as in Delphi, but in Delphi ANDROID is also POSIX.
https://www.freepascal.org/docs-html/prog/progap7.html

So I could add:

  {$IFDEF ANDROID}
    {$DEFINE POSIX}
  {$ENDIF ANDROID}

Regarding CPUARM64, it does not make sense that CPUARM corresponds to 32 bits. It should have been CPUARM32. Anyway, I can add:

  {$IFDEF CPUARM64}
    {$DEFINE CPUARM}
  {$ENDIF UNIX}

How does this sound?

[Alexey-T]

FPC docs
https://wiki.freepascal.org/Platform_defines#Architecture_defines

I came to this block

{$IFDEF FPC}
  {$IFDEF CPUARM}
    {$DEFINE CPUARM32}
  {$ENDIF}

  {$IFDEF CPUAARCH64}
    {$DEFINE CPUARM}
    {$DEFINE CPUARM64}
  {$ENDIF}

  {$IFDEF DARWIN}
    {$DEFINE OSX}
  {$ENDIF}

  {$IFDEF UNIX}
    {$DEFINE POSIX}
  {$ENDIF}
{$ENDIF}

/////////////////////////////////////////////////////////////////////////////
// Delphi, C++ Builder versions
/////////////////////////////////////////////////////////////////////////////  

[pyscripter]

A bit messy but I ended up with

{$IFDEF FPC}
  {$MODE DELPHI}

  {$IFDEF CPU64}
    {$DEFINE CPU64BITS}
  {$ENDIF CPU64}

  {$IFDEF CPU86}
    {$DEFINE CPUX86}
  {$ENDIF CPU86}

  {$IFDEF DARWIN}
    {$DEFINE OSX}
    {$DEFINE MACOS}
    {$IFDEF CPU32}
      {$DEFINE MACOS32}
    {$ENDIF CPU32}
    {$IFDEF CPU64}
      {$DEFINE MACOS64}
      {$DEFINE OSX64}
    {$ENDIF CPU64}
  {$ENDIF DARWIN}

  {$IFDEF CPUARM}
    {$DEFINE CPUARM32}
  {$ENDIF}

  {$IFDEF CPUAARCH64}
    {$DEFINE CPUARM}
    {$DEFINE CPUARM64}
  {$ENDIF}
  
  {$IFDEF UNIX}
    {$DEFINE POSIX}
  {$ENDIF UNIX}

  {$IFDEF ANDROID}
    {$DEFINE POSIX}
  {$ENDIF ANDROID}
{$ENDIF FPC}

which is a superset of yours.