Ensure that root_dir of DirectoryNode is created. (#618)

Author: tobiasraabe

docs/source/changes.md

@@ -8,6 +8,8 @@ releases are available on [PyPI](https://pypi.org/project/pytask) and
 ## 0.5.1 - 2024-xx-xx
 
 - {pull}`617` fixes an interaction with provisional nodes and `@mark.persist`.
+- {pull}`618` ensures that `root_dir` of `DirectoryNode` is created before the task is
+  executed.
 
 ## 0.5.0 - 2024-05-26
 

src/_pytask/execute.py

@@ -31,6 +31,7 @@
 from _pytask.node_protocols import PPathNode
 from _pytask.node_protocols import PProvisionalNode
 from _pytask.node_protocols import PTask
+from _pytask.nodes import DirectoryNode
 from _pytask.outcomes import Exit
 from _pytask.outcomes import SkippedUnchanged
 from _pytask.outcomes import TaskOutcome
@@ -173,6 +174,8 @@ def pytask_execute_task_setup(session: Session, task: PTask) -> None:  # noqa: C
         node = dag.nodes[product]["node"]
         if isinstance(node, PPathNode):
             node.path.parent.mkdir(parents=True, exist_ok=True)
+        if isinstance(node, DirectoryNode) and node.root_dir:
+            node.root_dir.mkdir(parents=True, exist_ok=True)
 
 
 def _safe_load(node: PNode | PProvisionalNode, task: PTask, *, is_product: bool) -> Any:

tests/test_provisional.py

@@ -268,3 +268,26 @@ def task_example(path = DirectoryNode(root_dir=Path("files"), pattern="*.py")):
 
     result = runner.invoke(cli, [tmp_path.as_posix()])
     assert result.exit_code == ExitCode.OK
+
+
+@pytest.mark.end_to_end()
+def test_root_dir_is_created(runner, tmp_path):
+    source = """
+    from typing_extensions import Annotated
+    from pytask import DirectoryNode, Product
+    from pathlib import Path
+
+    def task_example(
+        root_path: Annotated[
+            Path, DirectoryNode(root_dir=Path("subfolder"), pattern="*.txt"), Product
+        ]
+    ):
+        root_path.joinpath("a.txt").write_text("Hello, ")
+        root_path.joinpath("b.txt").write_text("World!")
+    """
+    tmp_path.joinpath("task_module.py").write_text(textwrap.dedent(source))
+
+    result = runner.invoke(cli, [tmp_path.as_posix()])
+    assert result.exit_code == ExitCode.OK
+    assert tmp_path.joinpath("subfolder", "a.txt").exists()
+    assert tmp_path.joinpath("subfolder", "b.txt").exists()