pluginmanager does not run consider_module on setuptools plugins

[RonnyPfannschmidt]

while turning a local set of modules into a entry-point based pytest plugin i discovered that for based setuptools plugins we dont run consider_module

i'd like to clarify if we want/dont want to do that and how to warn users about that

@hpk42 @nicoddemus ping

[nicoddemus]

I think for consistency it should, unless there's a hidden reason which I'm not aware about.

For quick reference:

    def consider_module(self, mod):
        self._import_plugin_specs(getattr(mod, 'pytest_plugins', []))

[RonnyPfannschmidt]

@nicoddemus while looking at it, i really wonder about having a concept of dependent plugin again (in pluggy)

[nicoddemus]

Hmm how would one declare dependencies in that way? I suppose this dependency mechanism would have to work for both pytest_plugins and setuptools plugins.

[RonnyPfannschmidt]

@nicoddemus off hand i took a look at the way setup-tools plugins work, it cant be directly integrated without changing pluggy

[nicoddemus]

I might have misunderstood your first comment, but I thought you meant to introduce a way for plugins (loaded either by setuptools or the pytest_plugins mechanism) to declare dependencies on other plugins. If that's correct, I'm not sure how plugins declared using pytest_plugins would declare that they depend on other plugins.

[RonnyPfannschmidt]

@nicoddemus lets keep the generalized future concept out of the current issue

triggering registration, and being aware of dependencies orders are quite different beasts

as of now py.test has neither, both play into each other, but the triggering of registration should be a lot more simple

[nicoddemus]

as of now py.test has neither, both play into each other, but the triggering of registration should be a lot more simple

Agreed! 👍

[RonnyPfannschmidt]

@nicoddemus as current measure, should we ensure that for all plugin modules we do consider_module ?

that would allow to consolidate various importation details into a plugin registration hook

[nicoddemus]

as current measure, should we ensure that for all plugin modules we do consider_module ?

IMO definitely.

[RonnyPfannschmidt]

@nicoddemus ok, upcoming pr then ^^

[nicoddemus]

That would be in features right? Right on time for 3.1 then. 😉