simplyfy ascii escaping by using backslashreplace error handling #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
force-pushed
the
simplify-string-safening
branch
from
bf7d525
to
78a027e
Compare
RonnyPfannschmidt
changed the title
|
oh fun, it seems like this is broken due to bugs on older python3's :( |
nicoddemus
requested changes
Aug 31, 2017
| @@ -146,13 +145,7 @@ def _ascii_escaped(val): | |||
|
|
|||
| """ | |||
| if isinstance(val, bytes): | |||
| if val: | |||
There was a problem hiding this comment.
I think we should fallback to the old code in Python 3.3 and Python 3.4. It will make the current code uglier of course, but at least when we drop 3.4 we will get the chance of getting the better version.
If we don't merge this I fear we end up just forgetting about it.
There was a problem hiding this comment.
i will declare the a function sometime later to handle the detail
changelog/2734.trivial
Outdated
| @@ -0,0 +1 @@ | |||
| - simplify ascii string escaping by using the backslashreplace error handler | |||
There was a problem hiding this comment.
Nit: please use full sentences:
Internal refactor: simplify ascii string escaping by using the backslashreplace error handler in newer Python 3 versions.
|
Thanks @RonnyPfannschmidt, took the liberty of applying the change I suggested to the CHANGELOG and merging, hope you don't mind. 👍 |
nicoddemus
approved these changes
Sep 5, 2017
|
thanks for fixing what i missed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.