unify cli verbosity handling #3296
Conversation
RonnyPfannschmidt
force-pushed
the
verbosity-actions
branch
2 times, most recently
from
d7b9744 to
c1b14cf
Compare
|
Thank you very much for working on this!! |
RonnyPfannschmidt
force-pushed
the
verbosity-actions
branch
2 times, most recently
from
f1a8174 to
1dccfa4
Compare
| new_count = getattr(namespace, self.dest, 0) - 1 | ||
| setattr(namespace, self.dest, new_count) | ||
| # todo Deprecate config.quiet | ||
| namespace.quiet = getattr(namespace, 'quiet', 0) + 1 |
There was a problem hiding this comment.
Hmm do we really need to deprecate namespace.quiet? If all we need to do is to keep this line around, I wouldn't bother TBH.
There was a problem hiding this comment.
its random shitty data showing up in introspection
on top of that its half-dead zombie data and partially incorrect, it should go away
There was a problem hiding this comment.
We can't we remove it now? Is it because it might be used by thirdparty plugins?
| import argparse | ||
|
|
||
|
|
||
| class MoreQuietAction(argparse.Action): |
There was a problem hiding this comment.
Please add a docstring documenting why this class exists.
There was a problem hiding this comment.
I don't understand why we need this class. What does it fix?
There was a problem hiding this comment.
it implements a negative counter and backward compat hacking, it can be simplified later on but its necessary since argparse itself is kinda shitty ^^
There was a problem hiding this comment.
ah. It is needed to get rid of config.option.verbose -= config.option.quiet, right?
_pytest/3296.trivial
Outdated
| @@ -0,0 +1 @@ | |||
| unify cli verbosity handling | |||
There was a problem hiding this comment.
I would write something that makes sense to users:
Refactoring to unify how verbosity is handled internally.
And we also need a new feature entry:
New ``--verbosity`` flag to set verbosity level explicitly.
RonnyPfannschmidt
force-pushed
the
verbosity-actions
branch
from
1dccfa4 to
16779f3
Compare
based on pytest-dev#3294 (comment) we really shouldnt have N options we post mortem hack together to determine verbosity this change starts by unifying the data, we still need to handle deprecation/removal of config.quiet
RonnyPfannschmidt
force-pushed
the
verbosity-actions
branch
from
16779f3 to
37a5260
Compare
based on #3294 (comment)
we really shouldnt have N options we post mortem hack together to determine verbosity
this change starts by unifying the data, we still need to handle deprecation/removal of config.quiet