Update :class:pytest.PytestUnhandledCoroutineWarning to a deprecation; it will raise an error in pytest 8. [SQUASH]
#10012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Jun 1, 2022
graingert
force-pushed
the
graingert-patch-1
branch
from
287a93f
to
a7be13b
Compare
graingert
changed the title
graingert
changed the title
graingert
commented
Jul 29, 2022
| @@ -55,7 +55,6 @@ class PytestRemovedIn8Warning(PytestDeprecationWarning): | |||
| __module__ = "pytest" | |||
|
|
|||
|
|
|||
| @final | |||
| class PytestReturnNotNoneWarning(PytestDeprecationWarning): | |||
There was a problem hiding this comment.
@RonnyPfannschmidt requested that PytestReturnNotNoneWarning be a RemovedIn8Warning and I agree, but the @final decorator on RemovedIn8Warning prevents that.
nicoddemus
requested changes
Jul 31, 2022
nicoddemus
reviewed
Aug 3, 2022
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
graingert
changed the title
pytest.PytestUnhandledCoroutineWarning to a deprecation; it will raise an error in pytest 8.
|
@nicoddemus what do you think about making RemovedIn8Warning not-final? Ideally it would be sealed: mypyc/mypyc#846 rather than final |
|
I'm OK with making it not-final |
nicoddemus
approved these changes
Aug 5, 2022
nicoddemus
changed the title
pytest.PytestUnhandledCoroutineWarning to a deprecation; it will raise an error in pytest 8.pytest.PytestUnhandledCoroutineWarning to a deprecation; it will raise an error in pytest 8. [SQUASH]
RonnyPfannschmidt
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
currently the PytestUnhandledCoroutineWarning are a regular PytestWarning. However really they are just a more important special case of PytestReturnNotNoneWarning
If the plan is to upbraid PytestReturnNotNoneWarning into a PytestReturnNotNoneError in pytest 8, we should turn both of these into an error at the same time.
See #9956 (comment)
And #7363