Fix bug discovered due to the change in implicit-str-concat
#12378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
type: bug
Pierre-Sassoulas
changed the title
implicit-str-concat and bug discovered due to the changeimplicit-str-concat
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
Pierre-Sassoulas
force-pushed
the
fix-implicit-str-concat-and-discovered-bug-due-to-it
branch
from
398df71
to
5f1f3aa
Compare
webknjaz
reviewed
Oct 23, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12172 (comment). I must confess I just followed suggestion blindly and don't understand much 😄 Need to retro-engineer a little to understand what's happening.