🧪🚑 Pass a Codecov config to the action @ GHA #12508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RonnyPfannschmidt this probably doesn't need a change note and should be backported. |
RonnyPfannschmidt
added
backport 8.2.x
skip news
The pytest-dev#11921 update broke uploading coverage of the `main` branch (or any in-repo pushes for that matter) to Codecov 4 months ago. Version 4 requires an upload token to be provided and since there was no configuration for it, the upload was failing. But the step itself was showing up as successful due to `fail_ci_if_error: true` being set. The error is visible in the console output, though. This patch flips the setting to `fail_ci_if_error: false` and sets the Codecov upload token in the config in clear text. The non-secret part allows the PRs uploads to be more stable. Co-authored-by: Ronny Pfannschmidt <opensource@ronnypfannschmidt.de>
webknjaz
force-pushed
the
maintenance/gha-codecov-token
branch
from
e0f70a4
to
774d71a
Compare
|
@RonnyPfannschmidt this is auto-merge-ready now. |
|
UPD: it looks like the codecov action isn't picking up the config. Perhaps, it needs renaming. |
|
Let's try merging. Perhaps, it'll work once the config is in |
|
Not that comfortable with the token being public, but while Adding the Codecov token doesn't explicitly mention it, the web interface shows that as a possible option:
so I suppose we'll be fine. |
The-Compiler
approved these changes
Jun 21, 2024
Backport to 8.2.x: 💚 backport PR created✅ Backport PR branch: Backported as #12513 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
The #11921 update broke uploading coverage of the `main` branch (or any in-repo pushes for that matter) to Codecov 4 months ago. Version 4 requires an upload token to be provided and since there was no configuration for it, the upload was failing. But the step itself was showing up as successful due to `fail_ci_if_error: true` being set. The error is visible in the console output, though. This patch flips the setting to `fail_ci_if_error: false` and sets the Codecov upload token in the config in clear text. The non-secret part allows the PRs uploads to be more stable. Co-authored-by: Ronny Pfannschmidt <opensource@ronnypfannschmidt.de> (cherry picked from commit 9947ec3)
The-Compiler
pushed a commit
that referenced
this pull request
Jun 21, 2024
The #11921 update broke uploading coverage of the `main` branch (or any in-repo pushes for that matter) to Codecov 4 months ago. Version 4 requires an upload token to be provided and since there was no configuration for it, the upload was failing. But the step itself was showing up as successful due to `fail_ci_if_error: true` being set. The error is visible in the console output, though. This patch flips the setting to `fail_ci_if_error: false` and sets the Codecov upload token in the config in clear text. The non-secret part allows the PRs uploads to be more stable. Co-authored-by: Ronny Pfannschmidt <opensource@ronnypfannschmidt.de> (cherry picked from commit 9947ec3) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk@sydorenko.org.ua>
webknjaz
added a commit
to webknjaz/pytest
that referenced
this pull request
Jun 21, 2024
It's necessary since it seems that the currently used Codecov uploader doesn't read the token from config sometimes. This is a follow-up for pytest-dev#12508 which wasn't enough.
webknjaz
added
the
type: infrastructure
Glyphack
pushed a commit
to Glyphack/pytest
that referenced
this pull request
Jul 30, 2024
The pytest-dev#11921 update broke uploading coverage of the `main` branch (or any in-repo pushes for that matter) to Codecov 4 months ago. Version 4 requires an upload token to be provided and since there was no configuration for it, the upload was failing. But the step itself was showing up as successful due to `fail_ci_if_error: true` being set. The error is visible in the console output, though. This patch flips the setting to `fail_ci_if_error: false` and sets the Codecov upload token in the config in clear text. The non-secret part allows the PRs uploads to be more stable. Co-authored-by: Ronny Pfannschmidt <opensource@ronnypfannschmidt.de>
Glyphack
pushed a commit
to Glyphack/pytest
that referenced
this pull request
Jul 30, 2024
It's necessary since it seems that the currently used Codecov uploader doesn't read the token from config sometimes. This is a follow-up for pytest-dev#12508 which wasn't enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #11921 update broke uploading coverage of the
mainbranch (or any in-repo pushes for that matter) to Codecov 4 months ago. Version 4 requires an upload token to be provided and since there was no configuration for it, the upload was failing. But the step itself was showing up as successful due tofail_ci_if_error: truebeing set. The error is visible in the console output, though.This patch flips the setting to
fail_ci_if_error: falseand sets the Codecov upload token in the config in clear text. The non-secret part allows the PRs uploads to be more stable.