Allow custom fixture names for fixtures #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novas0x2a
force-pushed
the
fixture-custom-name
branch
from
c65bf43
to
4381248
Compare
|
LGTM but I'd rather let someone else do the merge as I don't know the fixture code 😉 Thanks! |
|
LGTM as well, but i'd like @hpk42 to be the one to merge this one |
|
👍 from me as well, I just think it is missing some mention in the docs (inclusive providing the rationale). |
|
Should I just add a new entry to the end of the fixture doc? |
When defining a fixture in the same module as where it is used, the function argument shadows the fixture name, which a) annoys pylint and b) can lead to bugs where you forget to request a fixture into a test method. This allows one to define fixtures with a different name than the name of the function, bypassing that problem.
novas0x2a
force-pushed
the
fixture-custom-name
branch
from
4381248
to
9577120
Compare
|
Pushed a new version that updates the docstring (oops, forgot to do that originally). Hopefully this suffices for docs. |
|
I guess so. Thanks! |
|
anything i can do to make merging this easier? |
|
I guess if nobody else steps up I'll just merge this later today and be prepared to take the blame if something goes wrong (though I can't see what would) 😆 |
RonnyPfannschmidt
added a commit
that referenced
this pull request
Mar 14, 2016
Allow custom fixture names for fixtures
|
👍 |
This was referenced Aug 24, 2016
This was referenced Nov 16, 2017
Merged
This was referenced Nov 27, 2017
This was referenced Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When defining a fixture in the same module as where it is used, the
function argument shadows the fixture name, which a) annoys pylint and
b) can lead to bugs where you forget pull a fixture into a test method.
This allows one to define fixtures with a custom name override,
bypassing that problem.
I felt a little weird about thanking myself in the changelog.