-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
showing pytest warnings summary by default. #1672
Conversation
* added ``--disable-pytest-warnings` flag to let users disable the warnings summary. * extended/changed unit tests for the changes in the pytest core.
@@ -36,6 +36,10 @@ | |||
Thanks `@bagerard`_ for reporting (`#1503`_). Thanks to `@davehunt`_ and | |||
`@tomviner`_ for PR. | |||
|
|||
* Whitelisted pytest warnings to show up warnings summary by default. Added a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Whitelisted pytest warnings" seems confusing - it sounds like some warnings are on a whitelist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rephrase this once I get to a place with a stable internet connection :)
With the goal of keeping commandline options low you mentioned in #1668, what's the reason of using a quite specific |
I don't have a preference on the commandline options here. I was talking to Holger about this, also about inverse options and the conclusion was that adding the |
This should be rebased on @aostr could you please rebase into Also, please add a line "Fix #1668" in a commit so that issue gets closed automatically when merged. 😁 |
@@ -20,10 +20,15 @@ def pytest_addoption(parser): | |||
group._addoption('-q', '--quiet', action="count", | |||
dest="quiet", default=0, help="decrease verbosity."), | |||
group._addoption('-r', | |||
action="store", dest="reportchars", default=None, metavar="chars", | |||
action="store", dest="reportchars", default='', metavar="chars", | |||
help="show extra test summary info as specified by chars (f)ailed, " | |||
"(E)error, (s)skipped, (x)failed, (X)passed (w)pytest-warnings " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but also I think we should remove (w)pytest-warnings
from the list as it no longer has an effect.
Hi,
Did the following
Additionally, I decided to add myself to the authors.