Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scope override inside metafunc.parametrize. Fixes #634 #1766

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Fixed scope override inside metafunc.parametrize. Fixes #634 #1766

merged 1 commit into from
Jul 25, 2016

Conversation

Stranger6667
Copy link
Contributor

@Stranger6667 Stranger6667 commented Jul 25, 2016

Hello, this is my initial approach to solve #634
I'm not very familiar with pytest codebase, so I'll appreciate any help here.
Thank you

P.S. Also #684 #661 #896 #531 are probably related to this issue

@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage increased (+0.004%) to 92.296% when pulling af362b3 on Stranger6667:issue634-scopes into d37af20 on pytest-dev:master.

@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage increased (+0.004%) to 92.296% when pulling e686f39 on Stranger6667:issue634-scopes into d37af20 on pytest-dev:master.

@RonnyPfannschmidt
Copy link
Member

@Stranger6667 good work, at first glance it indeed seems to solve quite many if not all of the related issues

@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage increased (+0.004%) to 92.301% when pulling d72afe7 on Stranger6667:issue634-scopes into a2b04d0 on pytest-dev:master.

@nicoddemus nicoddemus merged commit d72afe7 into pytest-dev:master Jul 25, 2016
@nicoddemus
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants