Pkg resources bugfix #1854
Pkg resources bugfix #1854
Conversation
|
unfortunately by design the import will have to happen in any case (pythe plugins load that way) so i dont see how your patch helps, |
| @@ -942,6 +941,7 @@ def _consider_importhook(self, args, entrypoint_name): | |||
| and find all the installed plugins to mark them for re-writing | |||
| by the importhook. | |||
| """ | |||
| import pkg_resources | |||
| ns, unknown_args = self._parser.parse_known_and_unknown_args(args) | |||
| mode = ns.assertmode | |||
| if mode == 'rewrite': | |||
There was a problem hiding this comment.
@nicoddemus do we have a potential behaviour bug wrt plugin loading there
it seems to work as intended it shouldnt be in the else branch below
There was a problem hiding this comment.
I think it would be OK to move this to the else clause below, this would at least allow people to use plain if for some reason they don't have pkg_resources. OTOH if we really want to support running py.test without pkg_resources, we probably would need to write a test for it to ensure we don't break it again by accident.
@raquel-ucl is moving the import enough for you in Jython? It seems _consider_importhook function will be called regardless of the value of the --assert= option, so I think it will still break for you.
Btw, are you using --assert=plain?
There was a problem hiding this comment.
Sorry, I haven't been able to properly test this on my code yet because the Maven plugin is a bit of a black box for me still. But you are right, the import needs to be moved to the else clause, this change won't be enough. I'll do that. I'd like to help with the test as well, but I think I will need your help :)
About assert=plain I didn't know about it! I'll modify my code to use it. Thanks!
I'll have a closer look at the plugin I'm using to install the Python modules and see if I can make any sense of it.
|
I don't still don't get how pytest did work for you before v3 without |
|
@raquel-ucl is everything ok on your side and do you plan to follow up on this PR ? |
Related to #1853.