Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix issue pytest_plugins as string was marking wrong modules for rewrite #1891
Unfortunately due to a small bug on how the
pytest_plugins = 'setuptools.tests.fixtures'
The code that handles that in
def consider_module(self, mod): plugins = getattr(mod, 'pytest_plugins', ) self.rewrite_hook.mark_rewrite(*plugins) self._import_plugin_specs(plugins)
So it would end up marking each letter in
Coupling that with some advanced bootstrapping done in
Initially I started the investigation for this issue by implementing the optional
Beside testing locally, I opened pypa/setuptools#768 to make sure the fix worked.
This fixes #1888