New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch a special case in scope node lookup to a general one #2910

Merged
merged 2 commits into from Nov 10, 2017

Conversation

Projects
None yet
3 participants
@RonnyPfannschmidt
Member

RonnyPfannschmidt commented Nov 10, 2017

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
  • Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS, in alphabetical order;
@coveralls

This comment has been minimized.

coveralls commented Nov 10, 2017

Coverage Status

Coverage decreased (-0.002%) to 92.681% when pulling c47dcaa on RonnyPfannschmidt:scopenode-sanitize-specials into c33074c on pytest-dev:features.

@coveralls

This comment has been minimized.

coveralls commented Nov 10, 2017

Coverage Status

Coverage decreased (-0.002%) to 92.681% when pulling c47dcaa on RonnyPfannschmidt:scopenode-sanitize-specials into c33074c on pytest-dev:features.

scopename2class.update({
'class': _pytest.python.Class,
'module': _pytest.python.Module,
'function': _pytest.main.Item,
'session': _pytest.main.Session,

This comment has been minimized.

@nicoddemus
@coveralls

This comment has been minimized.

coveralls commented Nov 10, 2017

Coverage Status

Coverage decreased (-0.002%) to 92.681% when pulling 0108f26 on RonnyPfannschmidt:scopenode-sanitize-specials into c33074c on pytest-dev:features.

@nicoddemus nicoddemus merged commit 99496d9 into pytest-dev:features Nov 10, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RonnyPfannschmidt RonnyPfannschmidt deleted the RonnyPfannschmidt:scopenode-sanitize-specials branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment