Assume not skipped by mark if attribute missing #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failures appear to be a combination of PyPI flakiness and unrelated test flakiness. |
RonnyPfannschmidt
approved these changes
Jan 4, 2018
|
the failures seem unrelated, |
| @@ -261,7 +261,7 @@ def pytest_runtest_makereport(item, call): | |||
| else: | |||
| rep.outcome = "passed" | |||
| rep.wasxfail = explanation | |||
| elif item._skipped_by_mark and rep.skipped and type(rep.longrepr) is tuple: | |||
| elif getattr(item, '_skipped_by_mark', False) and rep.skipped and type(rep.longrepr) is tuple: | |||
There was a problem hiding this comment.
Couldn't it be isinstance(rep.longrepr, tuple) ?
There was a problem hiding this comment.
It could be, but I think it is fine to only expect only tuple types (as opposed to also expect tuple subclasses).
|
Thanks @elliterate and sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3074.