Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue to call finalizers in the stack when a finalizer raises an exception #3570

Merged
merged 3 commits into from
Jun 12, 2018

Conversation

sangongs
Copy link

Issue #3569

@nicoddemus
Copy link
Member

Thanks a lot @sangongs for the PR, we really appreciate it.

Your initial PR failed because it failed during linting, more specifically black (check step 3 of the long version in the contributing guide). I took the liberty of fixing it myself and pushing to your branch. 👍

Once again thanks for the PR!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 92.726% when pulling 4112596 on sangongs:fix_stack_finalizer into 04b65cf on pytest-dev:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants