-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don`t parse compat properties as fixtures #4164
don`t parse compat properties as fixtures #4164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4164 +/- ##
==========================================
- Coverage 95.87% 95.85% -0.02%
==========================================
Files 109 109
Lines 24626 24610 -16
Branches 2395 2395
==========================================
- Hits 23609 23591 -18
- Misses 721 722 +1
- Partials 296 297 +1
Continue to review full report at Codecov.
|
Hi @RonnyPfannschmidt, this seems to be working fine, why is it a RFC? Seems like it gets rid of the warnings about compat-properties during fixture collection quite nicely. 👍 |
@nicoddemus mainly because i skipped on tests and the docs |
Oh OK, I was under an erroneous definition of what |
no, i was ^^ |
cfaa19e
to
b55f5eb
Compare
this avoid triggering the warnings when parsing the session node as session plugin
b55f5eb
to
da04ff5
Compare
Fix #2701
its tricky to trigger those warnings under normal circumstances as they happen before pytest hooks into the warnings system
python -W always -m pytest testing/test_tmpdir.py --collectonly
could be used to trigger them for example on the cli