Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when a recursive dependency between fixtures is detected #4207

Merged
merged 1 commit into from
Oct 20, 2018

Conversation

nicoddemus
Copy link
Member

Fix #2909

@codecov
Copy link

codecov bot commented Oct 20, 2018

Codecov Report

Merging #4207 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4207      +/-   ##
=========================================
- Coverage   95.81%   95.8%   -0.01%     
=========================================
  Files         109     109              
  Lines       24257   24314      +57     
  Branches     2390    2405      +15     
=========================================
+ Hits        23242   23295      +53     
- Misses        720     722       +2     
- Partials      295     297       +2
Flag Coverage Δ
#docs 28.51% <0%> (ø) ⬆️
#doctesting 28.51% <0%> (ø) ⬆️
#linting 28.51% <0%> (ø) ⬆️
#linux 95.58% <100%> (-0.01%) ⬇️
#nobyte 91.89% <100%> (+0.01%) ⬆️
#numpy 92.86% <100%> (-0.04%) ⬇️
#pexpect 41.26% <0%> (-0.01%) ⬇️
#py27 93.94% <100%> (ø) ⬆️
#py34 92.23% <100%> (+0.04%) ⬆️
#py35 92.24% <100%> (+0.04%) ⬆️
#py36 93.89% <100%> (-0.01%) ⬇️
#py37 92.26% <100%> (+0.03%) ⬆️
#trial 92.86% <100%> (-0.04%) ⬇️
#windows 94.05% <100%> (ø) ⬆️
#xdist 93.78% <100%> (+0.15%) ⬆️
Impacted Files Coverage Δ
src/_pytest/fixtures.py 97.3% <100%> (ø) ⬆️
testing/python/fixture.py 99.24% <100%> (ø) ⬆️
src/_pytest/capture.py 93.36% <0%> (-0.46%) ⬇️
src/_pytest/logging.py 95.66% <0%> (-0.11%) ⬇️
testing/logging/test_reporting.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0eed7b...02ae7d8. Read the comment docs.

@crazymerlyn crazymerlyn merged commit cd72e23 into pytest-dev:master Oct 20, 2018
@nicoddemus nicoddemus deleted the recursive-dep-fixtures branch October 20, 2018 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants