Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/RFC: add failing test_capture_with_testdir_parseconfig [ci skip] #4331

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 7, 2018

Fails with:

OSError: reading from stdin while output is captured

Also tests #4330 (i.e. fails
without #4330 earlier already).

Closes #4329.

@blueyed
Copy link
Contributor Author

blueyed commented Nov 7, 2018

@nicoddemus
Seems to be related to capturing being done, although it should stay resumed.

@blueyed blueyed added type: bug problem that needs to be addressed plugin: capture related to the capture builtin plugin labels Nov 7, 2018
@blueyed
Copy link
Contributor Author

blueyed commented Nov 8, 2018

This is also a problem when trying to step over:

> …/src/_pytest/pytester.py(882)

 873         def runpytest_inprocess(self, *args, **kwargs):                                                                                                                  
 874             """Return result of running pytest in-process, providing a similar                                                                                           
 875             interface to what self.runpytest() provides.                                                                                                                 
 876                                                                                                                                                                          
 877             """                                                                                                                                                          
 878             if kwargs.get("syspathinsert"):                                                                                                                              
 879                 self.syspathinsert()                                                                                                                                     
 880             now = time.time()                                                                                                                                            
 881             capture = MultiCapture(Capture=SysCapture)                                                                                                                   
 882  ->         capture.start_capturing()                                                                                                                                    

I guess MultiCapture.start_capturing should honor some global state (which
remembers if there is capturing in place already), or the debugging plugin
needs to be able to interfere when capturing is suspended via it already.

Maybe this should use the CaptureManager in the first place here, instead of
MultiCapture directly?

@blueyed blueyed force-pushed the test_capture_with_testdir_parseconfig branch from 5fd5e07 to 255d553 Compare November 8, 2018 20:07
@blueyed blueyed force-pushed the test_capture_with_testdir_parseconfig branch from 255d553 to ce0ed9c Compare November 14, 2018 08:44
@blueyed
Copy link
Contributor Author

blueyed commented Nov 14, 2018

Failure can be seen at https://travis-ci.org/pytest-dev/pytest/jobs/454881133#L539.

@nicoddemus
Any pointers/ideas how to fix this?
Should there be an internal level/stacking for this?

Fails with:

> OSError: reading from stdin while output is captured

Also tests pytest-dev#4330 (i.e. fails
without pytest-dev#4330 earlier already).
@blueyed blueyed force-pushed the test_capture_with_testdir_parseconfig branch from ce0ed9c to 11478c5 Compare February 8, 2019 22:33
@nicoddemus
Copy link
Member

Hi @blueyed,

It has been a long time since it has last seen activity, plus we have made sweeping changes on master to drop Python 2.7 and 3.4 support, so this PR has some conflicts which require attention.

In order to clear up our queue and let us focus on the active PRs, I'm closing this PR for now.

Please don't consider this a rejection of your PR, we just want to get this out of sight until you have the time to tackle this again. If you get around to work on this in the future, please don't hesitate in re-opening this!

Thanks for your work, the team definitely appreciates it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: capture related to the capture builtin plugin type: bug problem that needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: '>' not supported between instances of 'NoneType' and 'float'
2 participants