Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case for #4500 and respective fix #4487 #4501

Merged
merged 4 commits into from
Dec 3, 2018

Conversation

s0undt3ch
Copy link
Contributor

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Include new tests or update existing tests when applicable.

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #4501 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4501      +/-   ##
==========================================
+ Coverage   95.88%   95.91%   +0.02%     
==========================================
  Files         111      111              
  Lines       25086    25093       +7     
  Branches     2448     2448              
==========================================
+ Hits        24054    24068      +14     
+ Misses        726      724       -2     
+ Partials      306      301       -5
Flag Coverage Δ
#docs 30.08% <0%> (+0.06%) ⬆️
#doctesting 30.08% <0%> (+0.06%) ⬆️
#linting 30.08% <0%> (+0.06%) ⬆️
#linux 95.73% <100%> (+0.02%) ⬆️
#nobyte 92.68% <100%> (+0.01%) ⬆️
#numpy 93.45% <100%> (ø) ⬆️
#pexpect 41.85% <0%> (-0.02%) ⬇️
#py27 94.05% <100%> (+0.02%) ⬆️
#py34 92.19% <100%> (+0.07%) ⬆️
#py35 92.21% <100%> (+0.07%) ⬆️
#py36 92.23% <100%> (+0.07%) ⬆️
#py37 94.12% <100%> (+0.03%) ⬆️
#trial 93.45% <100%> (ø) ⬆️
#windows 94.13% <100%> (ø) ⬆️
#xdist 93.98% <100%> (ø) ⬆️
Impacted Files Coverage Δ
testing/test_capture.py 99.24% <100%> (ø) ⬆️
src/_pytest/capture.py 93.66% <0%> (+0.45%) ⬆️
src/_pytest/terminal.py 92.95% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc5c84...6da8bef. Read the comment docs.

@asottile asottile merged commit 99d3fe2 into pytest-dev:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants