Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling fixtures directly is now an error instead of a warning #4561

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Calling fixtures directly is now an error instead of a warning #4561

merged 1 commit into from
Dec 19, 2018

Conversation

nicoddemus
Copy link
Member

Fix #4545

asottile
asottile approved these changes Dec 19, 2018
View reviewed changes
src/_pytest/deprecated.py Show resolved Hide resolved
@nicoddemus nicoddemus force-pushed the remove-calling-fixtures-directly branch from b488faf to 0115766 Compare December 19, 2018 11:26
RonnyPfannschmidt
RonnyPfannschmidt approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely - with this in place we can soon replace it with actual fixture definition objects

@nicoddemus
Copy link
Member Author

The travis failure is unrelated: #4563

@nicoddemus nicoddemus merged commit c400d8b into pytest-dev:features Dec 19, 2018
@nicoddemus nicoddemus deleted the remove-calling-fixtures-directly branch December 19, 2018 13:37
@cript0nauta cript0nauta mentioned this pull request Jan 2, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicoddemus @RonnyPfannschmidt @asottile