Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.6] Backport #5389 #5401

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Conversation

nicoddemus
Copy link
Member

No description provided.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus
Copy link
Member Author

Small nitpick: Would you mind we change the instructions on #5275 (comment) to use backport-XXXX instead of backport_XXXX? 😁

@asottile
Copy link
Member

asottile commented Jun 5, 2019

done! dashes are nicer, the shift key is sadness (shakes fist at black and double quotes)

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #5401 into 4.6-maintenance will increase coverage by 1.22%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           4.6-maintenance   #5401      +/-   ##
==================================================
+ Coverage            94.28%   95.5%   +1.22%     
==================================================
  Files                  115     115              
  Lines                26362   26562     +200     
  Branches              2603    2622      +19     
==================================================
+ Hits                 24855   25368     +513     
+ Misses                1178     887     -291     
+ Partials               329     307      -22
Impacted Files Coverage Δ
src/_pytest/config/__init__.py 94.43% <ø> (+0.63%) ⬆️
testing/test_config.py 99.83% <100%> (+0.34%) ⬆️
testing/test_unittest.py 71.82% <0%> (-27.28%) ⬇️
src/_pytest/unittest.py 84.61% <0%> (-9.6%) ⬇️
src/_pytest/main.py 96.06% <0%> (+0.21%) ⬆️
src/_pytest/fixtures.py 97.55% <0%> (+0.27%) ⬆️
testing/test_capture.py 99.25% <0%> (+0.29%) ⬆️
src/_pytest/python.py 93.33% <0%> (+0.36%) ⬆️
testing/test_pdb.py 98.44% <0%> (+0.38%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 937f945...0ae2771. Read the comment docs.

@asottile asottile merged commit 21680ff into pytest-dev:4.6-maintenance Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants