Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `slow` marker in run/skip option example. #5416

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@rillian
Copy link
Contributor

commented Jun 6, 2019

The example implementation of a --runslow option results in
a PytestUnknownMarkWarning. Include registering the custom
mark in the example, based on the documentation in markers.rst.

  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Add yourself to AUTHORS in alphabetical order;
@nicoddemus
Copy link
Member

left a comment

Thanks a lot @rillian, appreciate it! 👍

@rillian rillian force-pushed the rillian:runslow branch from c3def77 to 58062d7 Jun 6, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 6, 2019

Codecov Report

Merging #5416 into master will decrease coverage by 20.74%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5416       +/-   ##
===========================================
- Coverage   95.98%   75.24%   -20.75%     
===========================================
  Files         114      114               
  Lines       25523    25523               
  Branches     2480     2480               
===========================================
- Hits        24499    19204     -5295     
- Misses        718     5869     +5151     
- Partials      306      450      +144
Impacted Files Coverage Δ
testing/test_session.py 16.12% <0%> (-83.88%) ⬇️
testing/test_stepwise.py 17.24% <0%> (-82.76%) ⬇️
testing/python/show_fixtures_per_test.py 17.64% <0%> (-82.36%) ⬇️
testing/python/setup_plan.py 20% <0%> (-80%) ⬇️
testing/logging/test_reporting.py 20.19% <0%> (-79.48%) ⬇️
testing/python/setup_only.py 21.42% <0%> (-78.58%) ⬇️
testing/python/collect.py 21.65% <0%> (-77.71%) ⬇️
testing/test_unittest.py 22.37% <0%> (-76.72%) ⬇️
testing/python/fixtures.py 22.61% <0%> (-76.48%) ⬇️
testing/test_doctest.py 24.13% <0%> (-75.87%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450d264...58062d7. Read the comment docs.

@rillian rillian force-pushed the rillian:runslow branch from 58062d7 to bd1983d Jun 6, 2019

@rillian

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

Thanks for the quick review and lint fix. Sorry for clobbering!

Show resolved Hide resolved doc/en/example/simple.rst Outdated
Add `slow` marker in run/skip option example.
The example implementation of a `--runslow` option results in
a `PytestUnknownMarkWarning`. Include registering the custom
mark in the example, based on the documentation in markers.rst.

@rillian rillian force-pushed the rillian:runslow branch from bd1983d to 9182687 Jun 6, 2019

@blueyed

blueyed approved these changes Jun 6, 2019

@nicoddemus nicoddemus merged commit 042a10f into pytest-dev:master Jun 6, 2019

3 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pytest-CI #20190606.13 succeeded
Details

@rillian rillian deleted the rillian:runslow branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.