Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume os.dup is always available #6903

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Assume os.dup is always available #6903

merged 1 commit into from
Mar 13, 2020
+4 −58

Commits on Mar 12, 2020

  1. Assume os.dup is always available 

    The commit which added the checks for os.dup a15afb5
suggests it was done for Jython. But pytest doesn't support Jython
anymore (Jython is Python 2 only).

Furthermore, it looks like the faulthandler plugin (bundled in pytest
and enabled by default) uses os.dup() unprotected and there have not
been any complaints.

So seems better to just remove these checks, and only add if someone
with a legitimate use case complains.
    @bluetech
    bluetech committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    6954b3b View commit details
    Browse the repository at this point in the history