Adjust codecov: only patch statuses, wait for CI to pass #7294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect that only |
|
as per https://docs.codecov.io/docs/commit-status#excluding-tests-example, do we need to specify project as false? |
bluetech
reviewed
Jun 2, 2020
codecov.yml
Outdated
| comment: off | ||
| # reference: https://docs.codecov.io/docs/codecovyml-reference | ||
| codecov: | ||
| require_ci_to_pass: true |
There was a problem hiding this comment.
According to the reference this is the default, so maybe want to omit.
|
I think @gnikonorov is correct, though this section https://docs.codecov.io/docs/commit-status#disabling-a-status rather suggests coverage:
status:
project: off |
|
You folks are right! Funny thing, I was thinking exactly that this was the correct way in the shower this morning. 😆 |
nicoddemus
force-pushed
the
codecov-adjustments
branch
from
4dbea41
to
eaf46f5
Compare
bluetech
approved these changes
Jun 2, 2020
nicoddemus
added
the
needs backport
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Jun 2, 2020
|
Backport: #7299 |
bluetech
added a commit
that referenced
this pull request
Jun 2, 2020
[5.4.x] Merge pull request #7294 from nicoddemus/codecov-adjustments
nicoddemus
added
backported
and removed
needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6994