Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capture: fix disabled()/global_and_fixture_disabled() enabling capturing when it was disabled #7651

Merged
merged 1 commit into from
Aug 24, 2020

Commits on Aug 16, 2020

  1. capture: fix disabled()/global_and_fixture_disabled() enabling captur…

    …ing when it was disabled
    
    The `CaptureManager.global_and_fixture_disabled()` context manager (and
    `CaptureFixture.disabled()` which calls it) did `suspend(); ...;
    resume()` but if the capturing was already suspended, the `resume()`
    would resume it when it shouldn't.
    
    This caused caused some messages to be swallowed when `--log-cli` is
    used because it uses `global_and_fixture_disabled` when capturing is not
    necessarily resumed.
    bluetech committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    0d5a650 View commit details
    Browse the repository at this point in the history