New ALLOW_UNICODE doctest option #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabled, the ``u`` prefix is stripped from unicode strings in expected doctest output. This allows doctests which use unicode to run in Python 2 and 3 unchanged. Fix pytest-dev#710
Also make sure a test that doesn't set ALLOW_UNICODE fails on Python 2 and passes Python 3.
|
Any comments here @RonnyPfannschmidt? |
RonnyPfannschmidt
added a commit
that referenced
this pull request
Aug 16, 2015
New ALLOW_UNICODE doctest option
|
I've been meaning to test this in the fork. Now I'll plan to test it here. Thanks to both and I really look forward to this feature. |
|
The test works great on a known failing project. Thanks for this. It is slightly awkward that passing ALLOW_UNICODE causes tests to fail without this patch, but I guess that's an acceptable limitation, and certainly understandable. |
|
@jaraco, you can set in your config file to have ALLOW_UNICODE enabled by default. Would make sense if you use a lot of doctests on strings and have py2/3 support. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code and option copied from the nltk project.
Fixes #710.
cc @jaraco