(feat):add-google-tag-manager #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cprussin
reviewed
May 22, 2024
| "nextra-theme-docs": "latest", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-gtm-module": "^2.0.11", |
There was a problem hiding this comment.
Fine for now but do note this library isn't great with later versions of nextjs; in particular once I get us onto nextjs 14 and the app router across the board we will need to use something that leverages the nextjs Script component instead since it properly handles blocking / prioritization and CSP.
I don't know of any libraries that implement this out of the box but it's really trivial to do it manually -- I'll add it in after I migrate us.
There was a problem hiding this comment.
I will put a reminder if you need.
cprussin
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.