Rewrite themes and add support for light mode #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@cprussin is attempting to deploy a commit to the pyth-web Team on Vercel. A member of the Team first needs to authorize it. |
cprussin
force-pushed
the
cprussin/add-light-mode
branch
from
dc20b39 to
fe857e7
Compare
cprussin
force-pushed
the
cprussin/add-light-mode
branch
from
fe857e7 to
150e8e1
Compare
cprussin
force-pushed
the
cprussin/add-light-mode
branch
from
5e637a4 to
74f9877
Compare
cprussin
force-pushed
the
cprussin/add-light-mode
branch
from
74f9877 to
b7f3d6f
Compare
aditya520
approved these changes
May 24, 2024
cprussin
force-pushed
the
cprussin/add-light-mode
branch
from
b7f3d6f to
05096cb
Compare
cprussin
force-pushed
the
cprussin/add-light-mode
branch
from
05096cb to
8cdddd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the theming and adds support for a light & dark mode.
I've removed most of our custom theme overrides and instead I'm now using
primaryHueandprimarySaturationto get nextra to theme things reasonably out of the box. I've then added css overrides to refine some of the themes to match our desired designs. This should result in needing less overrides and also getting a reasonably on-brand result on things we forget to explicitly override.@aditya520 I'll need you to help QA the site to ensure everything looks good