Skip to content

fix(ci): fix CI js builds #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix(ci): fix CI js builds #2123

merged 1 commit into from
Nov 15, 2024

Conversation

cprussin
Copy link
Collaborator

This PR does a few related things:

  • Excludes nextjs packages from building on github as part of CI or before publishing js packages -- this is because these packages are intended to be built on Vercel and require system access & env vars to build that we don't have any good reason to expose to Github Actions

  • Adds a new github workflow to run the turbo build in github actions on any PRs that modify any ts/js files

  • Renames the "build" script for the pyth-ton package so it doesn't trigger on CI builds -- this script is an interactive build that doesn't seem to produce any results in a CI environment and so it shouldn't be included in the build on CI

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🛑 Canceled (Inspect) Nov 15, 2024 7:23pm
component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 7:23pm
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 7:23pm
proposals 🛑 Canceled (Inspect) Nov 15, 2024 7:23pm
staking 🛑 Canceled (Inspect) Nov 15, 2024 7:23pm

Copy link

vercel bot commented Nov 15, 2024

@cprussin is attempting to deploy a commit to the Pyth Network Team on Vercel.

A member of the Team first needs to authorize it.

This PR does a few related things:

- Excludes nextjs packages from building on github as part of CI or before
publishing js packages -- this is because these packages are intended to be
built on Vercel and require system access & env vars to build that we don't have
any good reason to expose to Github Actions

- Adds a new github workflow to run the turbo build in github actions on any PRs
that modify any ts/js files

- Renames the "build" script for the pyth-ton package so it doesn't trigger on
CI builds -- this script is an interactive build that doesn't seem to produce
any results in a CI environment and so it shouldn't be included in the build on
CI
@cprussin cprussin merged commit 6408b31 into pyth-network:main Nov 15, 2024
9 checks passed
@cprussin cprussin deleted the fix-publish branch November 15, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants